Author Topic: [1.6.2] (and up?) code inconsistency (quick fix I think, no functional problem)  (Read 1890 times)

markc

  • Freshman
  • *
  • Posts: 47
    • View Profile
I do not believe this to be causing a bug, and parts of it could be intentional, but it appears to be a copy/paste that wasn't fleshed out.

I'm sure there are bigger problems but I thought I'd make mention of it here...since I found no previous mention when searching for the function names.

In...

 ./application/models/contacts/Contact.class.php

getFullOtherAddress's comment says that is gets the full work address,

/**
         * Returns the full work address
         *
         * @return string
         */
        function getFullOtherAddress()
        {
                $line1 = $this->getOAddress();


getFullHomeAddress has no comment over it at all.

Also, even though these functions (I'm assuming) are the same except for the type of address they are retrieving, they differ in how they initialize some of their lines.