Author Topic: problem with comments  (Read 5054 times)

woland255

  • Freshman
  • *
  • Posts: 39
    • View Profile
problem with comments
« on: October 24, 2008, 01:59:43 am »
Good day to all.
When I post new comment "canEdit(logged_user()), true, false); if ($object_links_render != '') { ?>" appears at the right side of it. Nevertheless, all functionality (edit,link,delete) works.
Thanks.

ignacio

  • Hero Member
  • *****
  • Posts: 1703
    • View Profile
Re: problem with comments
« Reply #1 on: October 24, 2008, 09:24:40 am »
Can you upload a screenshot of how it looks like?

woland255

  • Freshman
  • *
  • Posts: 39
    • View Profile
Re: problem with comments
« Reply #2 on: October 25, 2008, 03:17:51 pm »
It looks like this (see attachment)

furins

  • Newbie
  • *
  • Posts: 10
    • View Profile
Re: problem with comments
« Reply #3 on: October 27, 2008, 07:39:28 am »
I've got similar errors (see also Internal server problem error http://forums.opengoo.org/index.php?topic=265.0 topic in the bugs forum)

the solution is simple

change, in application/views/comment/object_comments.php
at line 57
Code: [Select]
</td><? $object_links_renderwith
Code: [Select]
</td><?php $object_links_render
reason: when starting a php code area with the old-style "<?" tag will cause the tag to close at the next "->" chars, then when accessing $comment methods.

hope this help!  ;)
« Last Edit: October 27, 2008, 10:07:59 am by furins »

cabeza

  • Administrator
  • Hero Member
  • *****
  • Posts: 1004
    • View Profile
    • Feng Office
Re: problem with comments
« Reply #4 on: October 27, 2008, 09:55:59 am »
Thanks for the fix ...
Marcos

furins

  • Newbie
  • *
  • Posts: 10
    • View Profile
Re: problem with comments
« Reply #5 on: October 27, 2008, 11:40:28 am »
you're welcome!

for the sake of completeness, and hoping to save you time, I'd like to report another small bug related to the same kind of error  ::):

I think the only other place you forgot to use the "<?php" entry-tag is in application/views/task/index.php
at line 158 - (title="<? echo lang('print')?>").

This causes to erroneusly print "<? echo lang('print')?>" instead of localized  "print" in PHP5 (or, at least, with my php.ini configuration file), but ok - this is a very insignificant issue! nobody will never note it  :D

all the best!


ignacio

  • Hero Member
  • *****
  • Posts: 1703
    • View Profile
Re: problem with comments
« Reply #6 on: October 27, 2008, 01:20:30 pm »
Yes, this showed up in four other places in the code as well, all fixed now. Thanks again!

woland255

  • Freshman
  • *
  • Posts: 39
    • View Profile
Re: problem with comments
« Reply #7 on: October 28, 2008, 04:10:09 am »
Thank you, this  helps!  :)